Skip to content

Always gather resources from fips 6node jobs#80249

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
afcollins:perfscale-ipsec-gather
Jun 9, 2026
Merged

Always gather resources from fips 6node jobs#80249
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
afcollins:perfscale-ipsec-gather

Conversation

@afcollins

@afcollins afcollins commented Jun 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

A brief look at the fips jobs shows latencies that are wildly variable, and we skip the important gather steps to be able to dig in further.

This always gathers from the 6 node jobs, since they are configured to almost never fail on their own.

Summary by CodeRabbit

This PR ensures that resource gathering always executes for the FIPS 6-node test jobs across all OpenShift versions (4.21, 4.22, 4.23, and 5.0), regardless of whether earlier job steps succeed.

What changed: The allow_skip_on_success flag was set to false for the control-plane-fips-6nodes job in four CI configuration files. This job runs the following test chains using the AWS OVN FIPS workflow:

  • Worker node scaling
  • Control plane tests
  • Orion consolidated tests

Why this matters: FIPS 6-node jobs are designed to almost never fail on their own, which previously caused resource gathering and diagnostic collection steps to be skipped when the tests reported success. This prevented deeper investigation into the highly variable latencies observed in these FIPS jobs. By disabling the skip-on-success behavior, the gathering steps will now always execute, enabling better performance analysis and troubleshooting.

Files modified:

  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.21-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-5.0-nightly-x86.yaml

@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1e1b0414-d455-4db6-881e-f2a59e3af4ad

📥 Commits

Reviewing files that changed from the base of the PR and between 16971ab and f900606.

📒 Files selected for processing (4)
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.21-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-5.0-nightly-x86.yaml

Walkthrough

The pull request disables the skip-on-success behavior for the control-plane-fips-6nodes CI test job across four OpenShift nightly build configurations (versions 4.21, 4.22, 4.23, and 5.0). The steps.allow_skip_on_success flag is changed from true to false in each version-specific configuration file.

Changes

CI Configuration Update

Layer / File(s) Summary
Disable skip-on-success for control-plane-fips-6nodes across versions
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.21-nightly-x86.yaml, ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml, ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.23-nightly-x86.yaml, ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-5.0-nightly-x86.yaml		 The control-plane-fips-6nodes job's steps.allow_skip_on_success setting is toggled from true to false across all four version-specific nightly CI configurations, ensuring the test job runs even when preceding conditions indicate success.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ok-to-test

Suggested reviewers

  • deads2k
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: setting allow_skip_on_success to false ensures resource gathering always runs for FIPS 6-node jobs across multiple AWS configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check is not applicable: PR only modifies CI configuration YAML files and standard Go unit tests, not Ginkgo tests with test names.
Test Structure And Quality ✅ Passed PR modifies only CI/CD job configuration YAML files; contains no Ginkgo test code, making the test structure check inapplicable.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration YAML files and documentation. No new Ginkgo e2e tests are being added, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI operator configuration files (YAML) only, not test code. No Ginkgo e2e tests are added, so the SNO Test Compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only ci-operator CI/CD test configuration files, not deployment manifests, operator code, or controllers. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration files and shell scripts; no Go source code changes affecting OTE binaries or test framework code present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only CI operator configuration YAML files and utility tools. No new Ginkgo e2e tests (It(), Describe(), Context(), etc.) are added, so the IPv6/disconnected check does not apply.
No-Weak-Crypto ✅ Passed PR contains only YAML CI/CD configuration changes with no cryptographic code, weak crypto algorithms, or custom crypto implementations detected.
Container-Privileges ✅ Passed Modified files are CI operator configs without container/K8s manifests; no privileged configs found (privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation).
No-Sensitive-Data-In-Logs ✅ Passed PR only changes when gather steps run (always vs. on-failure). Gather steps use mco-sanitize to redact sensitive data from diagnostics. No new code logging sensitive data is introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from mcornea and mehabhalodiya June 8, 2026 18:58
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@afcollins: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.23-nightly-x86-control-plane-fips-6nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-5.0-nightly-x86-control-plane-fips-6nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.22-nightly-x86-control-plane-fips-6nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-control-plane-fips-6nodes N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

jtaleric
jtaleric approved these changes Jun 8, 2026
View reviewed changes

@jtaleric jtaleric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afcollins, jtaleric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afcollins

afcollins commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

openshift-merge-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@afcollins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@afcollins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c3964c2 into openshift:main Jun 9, 2026
14 checks passed
IshwarKanse pushed a commit to IshwarKanse/release that referenced this pull request Jun 9, 2026
@afcollins @IshwarKanse
Always gather resources from fips 6node jobs (openshift#80249)
86f5400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcornea mcornea Awaiting requested review from mcornea

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

1 more reviewer

@jtaleric jtaleric jtaleric approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtaleric jtaleric

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afcollins @jtaleric